Comments on: Bad Code Smells in WACT, a refactoring review

By: Breana Brannigan

Breana Brannigan — Tue, 10 Jan 2012 12:14:59 +0000

Jonny Dorey. VCU student. Found in the James river, Hopewell Marina Virginia.

By: Fax Free Internet

Fax Free Internet — Thu, 29 Dec 2011 07:39:31 +0000

somebody essentially help to make severely posts i’d state. this is the first time i frequented your website page and up to now? i amazed with the research you made to create this particular submit amazing. great activity!

By: lashes

lashes — Tue, 22 Nov 2011 06:42:07 +0000

Its like you study my mind! You appear to understand so substantially about this, like you wrote the book in it or anything. I assume that you simply could do with some pics to drive the message house a bit, but rather of that, this can be excellent blog. A excellent read. I’ll undoubtedly be back.

By: clamshell packaging

clamshell packaging — Fri, 11 Nov 2011 00:11:48 +0000

It’s hard to find knowledgeable people on this topic, but you sound like you know what you’re talking about! Thanks

By: military electronics

military electronics — Fri, 11 Nov 2011 00:11:36 +0000

Witty! I’m bookmarking you site for future use.

By: DIPTI.MALI

DIPTI.MALI — Wed, 27 Jul 2005 14:36:01 +0000

I am doing a project where i am anaylsing how bad code documenatation becomes a nightmare for new/future developer.
i would be obliged if u can help me in any form.
thanks……….

By: Harry Fuecks

Harry Fuecks — Tue, 26 Oct 2004 12:01:31 +0000

Great write up. Should confess I’m guilty in most cases – probably Shotgun Surgery.

Another one to watch is the relationship between ExpressionFilterFindingParser and ExpressionFilterParser (expression.inc.php) and in the latter, the ways Args is used is dubious.

Off the specific topic of bad smells, some particular issues;

The way compileall.inc.php works also needs review I think. For a start seems to bypass various code in a way that makes it’s behaviour unpredictable plus that constant WACT_ERROR_CONTINUE is a hack.

Find Jason’s list / script bug unsettling. The new HTMLParser is generally a big improvement but it’s now got embedded knowledge of HTML (the script tag). Somehow think we’re going to need to have a second stage of parsing. Also what about other document formats (where there happens to be some kind of script tag)?

Wonder if we need to consider some kind of document detection at last. There’s still the issue with form tags and XHTML. And if a document does claim to be well formed XML, perhaps we can switch to a real XML parser?

By: Marcus Baker

Marcus Baker — Mon, 25 Oct 2004 18:31:45 +0000

The bit that I’ve never understood is, what is a DataSpace? Do you have a release date planned for the next version?

By: pachanga

pachanga — Tue, 19 Oct 2004 11:04:55 +0000

Maybe it’s a bit offtopic, yet i find the following feature very important and nice to have in WACT – custom tags loader.
Something like WACT :: registerTagsLoader($loader);
WACT could use some default tags loader if none is registered.
This way it’ll simplify extending WACT by 3d party software tools…

By: Jeff Moore's Blog » Status of WACT

Jeff Moore's Blog » Status of WACT — Wed, 31 Dec 1969 19:00:00 +0000

[...] of WACT Filed under: PHP Software Development — admin @ 2:33 pm My last WACT post drew a couple questions from Marcus Baker [...]